CheckoutPage: submit button was enabled prematurely for onetime payments #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Gnito
commented
Sep 28, 2021
•
Gnito
commented
- If default payment method and onetime payment method were toggled, submit button was enabled prematurely. There was no check for valid Stripe Element card value, when selecting onetime payment option.
- Reselecting saved-payment-method flow after receiving an error from initial attempt of onetime-payment, didn't send payment method to Stripe correctly.
Gnito
force-pushed
the
fix-disable-checkoutpage-submit-button
branch
3 times, most recently
from
a9671c8
to
0316f7c
Compare
kpuputti
approved these changes
Sep 29, 2021
Gnito
force-pushed
the
fix-disable-checkoutpage-submit-button
branch
from
0316f7c
to
0c7b22c
Compare
This was referenced Nov 22, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.